doc: correct grammar in README.md#8892
doc: correct grammar in README.md#8892NoahDragon wants to merge 2 commits intonodejs:masterfrom NoahDragon:patch-1
Conversation
Fix some punctuations.
README.md
Outdated
| [Release Team](#release-team). | ||
| Code for Current releases is organized in this repository by major version | ||
| number, For example: [v4.x](https://github.com/nodejs/node/tree/v4.x). | ||
| number, For example, [v4.x](https://github.com/nodejs/node/tree/v4.x). |
There was a problem hiding this comment.
I think changing the preceding comma to a period would be a better change here:
number. For example: ...
README.md
Outdated
| The [latest](https://nodejs.org/download/release/latest/) directory is an | ||
| alias for the latest Current release. The latest LTS release from an LTS | ||
| line is available in the form: latest-_codename_. For example: | ||
| line is available in the form: latest-_codename_. For example, |
There was a problem hiding this comment.
IMHO colon looks better here.
|
LGTM |
NoahDragon
changed the title
|
Just wonder, when normally the PR will be merged after review? |
|
@NoahDragon The minimum is 48 hours, but we often wait a little longer. This has probably been long enough, so it's just a matter of a contributor having some time and merging it in. Should be soon though! |
|
CI run: https://ci.nodejs.org/job/node-test-pull-request/4377/ |
|
@gibfahn Thanks for the clarification. |
|
I'm seeing two linter failures, which are caused by #8873. I'll start merging this now, I think it's been long enough for a doc change.
$ make lint
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules \
benchmark lib test tools
/Users/gib/dev/node/lib/_stream_readable.js
664:30 error 'i' is constant no-const-assign
670:9 error 'i' is already defined no-redeclare
✖ 2 problems (2 errors, 0 warnings)
make: *** [jslint] Error 1 |
|
master is fixed, try again |
PR-URL: #8892 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Linter failures resolved, linter now passes cleanly. Landed in e10516d, thanks a lot @NoahDragon. BTW @NoahDragon you changed the title of the PR, but not the name of the commit. In general the commit should start with |
|
@gibfahn Thank you. |
|
How to become a Nodejs Foundation Member, I saw the website saying that anyone has contributed to Nodejs projects can grant free membership (Ref). I know that I only did a really little contribution based on this PR, but do I qualified to become a Nodejs Foundation member on Github, or I still need to contribute more? I will continue contributing Nodejs community because I'm maintaining a static generator (Hexo) which heavily relies on nodejs functionalities. I don't know where to ask this question, and don't want to mess up the issue board. So I asked it here. Please forgive me if I posted it at wrong place. |
|
cc @mikeal for details generally I think if you get added to the org (you've done enough to become part of a team, working group, or a core collaborator), you have access to it. It may be removed in the future if you are inactive iirc. You're best shot is to consistently contribute. ;) |
|
Thank you @Fishrock123 |
PR-URL: #8892 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #8892 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Correct me if I'm wrong, based on the website (https://nodejs.org/en/foundation/members/#becoming-an-individual-member), I think any contributor could become a Nodejs Foundation member. Do I misunderstand it or there are some conditions on it? Any reply are appreciated. |
7 participants
Checklist
Affected core subsystem(s)
Description of change
Fix some punctuations.